Update request based on latest data contract #1919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-ayoub-segment
approved these changes
Mar 13, 2024
|
hi @AlliterativeAlice - PR deployed. Please confirm that you are happy with the change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After testing our Segment destination and reviewing our use cases, we have made changes to our backend server which change the data contract between the destination:
ua_fwdURL parameter which is populated with the user agent string.argsparameter.Testing
Modified existing unit tests based on the new data contract
Manually tested that expected parameters are sent to our backend server
Added unit tests for new functionality
Tested end-to-end using the local server
[Segmenters] Tested in the staging environment