Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MultiStatus] Improve error handling and two new methods to MultiStatus Class #2424

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

sayan-das-in
Copy link
Contributor

This PR adds two new methods to MultiStatusResponse class

  • Adds two new methods to MultiStatusResponse class
  • Adds error handling to handle an edge case when elements at an index could be undefined resulting in an exception

Testing

Tested locally and with unit tests.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [Segmenters] Tested in the staging environment

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.70%. Comparing base (aa13cef) to head (112144c).

Files with missing lines Patch % Lines
packages/core/src/destination-kit/action.ts 70.00% 3 Missing ⚠️
packages/core/src/destination-kit/index.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2424      +/-   ##
==========================================
- Coverage   82.97%   82.70%   -0.27%     
==========================================
  Files         948     1168     +220     
  Lines       16572    20921    +4349     
  Branches     3135     4186    +1051     
==========================================
+ Hits        13750    17303    +3553     
- Misses       2628     3422     +794     
- Partials      194      196       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@varadarajan-tw varadarajan-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left one comment.

packages/core/src/destination-kit/action.ts Outdated Show resolved Hide resolved
varadarajan-tw
varadarajan-tw previously approved these changes Sep 20, 2024
@sayan-das-in sayan-das-in requested a review from a team as a code owner September 20, 2024 11:08
@sayan-das-in sayan-das-in merged commit f3c03cd into main Sep 20, 2024
11 of 13 checks passed
@sayan-das-in sayan-das-in deleted the multistatus-updates branch September 20, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants