Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Crypto abstract methods public #632

Merged
merged 2 commits into from
Mar 23, 2020

Conversation

jgavris
Copy link
Contributor

@jgavris jgavris commented Sep 18, 2019

It's not currently possible to plug in a custom Crypto implementation for storing analytics events on disk since these abstract methods have default / package visibility.

@codecov-io
Copy link

codecov-io commented Sep 18, 2019

Codecov Report

Merging #632 into master will decrease coverage by 0.27%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #632      +/-   ##
==========================================
- Coverage   83.43%   83.16%   -0.28%     
==========================================
  Files          31       31              
  Lines        2512     2512              
  Branches      292      292              
==========================================
- Hits         2096     2089       -7     
- Misses        329      335       +6     
- Partials       87       88       +1
Impacted Files Coverage Δ
...cs/src/main/java/com/segment/analytics/Crypto.java 100% <ø> (ø) ⬆️
...java/com/segment/analytics/SegmentIntegration.java 81.9% <100%> (ø) ⬆️
.../src/main/java/com/segment/analytics/ValueMap.java 86.39% <0%> (-2.73%) ⬇️
...ain/java/com/segment/analytics/internal/Utils.java 74.13% <0%> (-1.15%) ⬇️
...cs/src/main/java/com/segment/analytics/Traits.java 92.3% <0%> (-1.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47f7341...0834422. Read the comment docs.

@bsneed bsneed merged commit 0040419 into segmentio:master Mar 23, 2020
@bsneed
Copy link
Contributor

bsneed commented Mar 23, 2020

thanks @jgavris !

@jgavris jgavris deleted the fix-crypto branch March 23, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants