Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate timestamps at call site rather than asynchronously #686

Merged
merged 2 commits into from
Jul 30, 2020

Conversation

prayansh
Copy link
Contributor

This PR implements generation of timestamps for payloads at call site rather than asynchronously, enabling us to generate more accurate timestamps for each payload. This feels like it should be a default behaviour and is thus not behind a feature flag.

This should not have a major performance impact, since we only add the generation of a timestamp to the main thread.

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2020

Codecov Report

Merging #686 into master will decrease coverage by 0.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #686      +/-   ##
==========================================
- Coverage   27.35%   27.24%   -0.12%     
==========================================
  Files          32       32              
  Lines        2716     2727      +11     
  Branches      318      318              
==========================================
  Hits          743      743              
- Misses       1918     1929      +11     
  Partials       55       55              
Impacted Files Coverage Δ
...src/main/java/com/segment/analytics/Analytics.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f129d4d...f42ad56. Read the comment docs.

@prayansh prayansh merged commit 9657e96 into master Jul 30, 2020
@prayansh prayansh deleted the pray/gen-timestamps-call branch July 30, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants