Check Double NaN and Infinity Values #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #752 +/- ##
==========================================
+ Coverage 81.36% 81.38% +0.01%
==========================================
Files 34 34
Lines 2866 2869 +3
Branches 342 344 +2
==========================================
+ Hits 2332 2335 +3
Misses 420 420
Partials 114 114
Continue to review full report at Codecov.
|
prayansh
approved these changes
Mar 16, 2021
| @@ -212,6 +212,10 @@ private static void writeValue(Object value, JsonWriter writer) throws IOExcepti | |||
| if (value == null) { | |||
| writer.nullValue(); | |||
| } else if (value instanceof Number) { | |||
| if (value instanceof Double | |||
| && (Double.isNaN((Double) value) || Double.isInfinite((Double) value))) { | |||
| value = 0; | |||
There was a problem hiding this comment.
lets make the value explicity 0.0, to conform to a double value
| @@ -298,6 +298,27 @@ class CartographerTest { | |||
| ) | |||
| } | |||
|
|
|||
| @Test | |||
| @Throws(IOException::class) | |||
| fun encodesInfiniteAndNanDoubles() { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NaN vales are being added to our JSON payload resulting in the entire payload failing. Check for these vales and now set to zero.