switch to a maintained uuid library #150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Same as what I mentioned in #149, the master branch contains code for the v2 version which has been deprecated and is no longer maintained. |
|
I'll update this one against the V3 branch |
thaJeztah
force-pushed
the
maintained_uuid
branch
from
5b6138d
to
a34f232
Compare
|
updated, but looked like there were issues with the vendor directory in the V3 branch as well, so opened #151, and based this one on top of that |
thaJeztah
commented
Apr 14, 2019
| @@ -1,3 +0,0 @@ | |||
| [submodule "vendor/github.com/bmizerany/assert"] | |||
There was a problem hiding this comment.
Couldn't find references to this package, so guess this was ok to remove
|
Hi @f2prateek and @williamgrosset, did you have a chance to look at this PR? |
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The github.com/xtgo/uuid library has not been updated since 5 years, and may well be buggy. Use the google/uuid library instead, which is actively maintained, tested, and widely in use (e.g., in Docker, Kubernetes). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
maintained_uuid
branch
from
a34f232
to
904b59f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The github.com/xtgo/uuid library has not been updated since 5 years, and may well be buggy. Use the google/uuid library instead, which is actively maintained, tested, and widely in use (e.g., in Docker, Kubernetes).
I based this on top of #151, and will rebase once that is merged