LIBMOBILE-109: Updated an issue with new traits not overriding old tr…

…aits (#917)
segmentio · Jul 6, 2020 · b82f0ed · b82f0ed
1 parent 5158e55
commit b82f0ed
Showing 1 changed file with 12 additions and 9 deletions.
diff --git a/Analytics/Classes/SEGAnalytics.m b/Analytics/Classes/SEGAnalytics.m
@@ -223,25 +223,28 @@ - (void)identify:(NSString *)userId traits:(NSDictionary *)traits options:(NSDic
         anonId = [self getAnonymousId];
     }
     // configure traits to match what is seen on android.
-    NSMutableDictionary *newTraits = [traits mutableCopy];
+    NSMutableDictionary *existingTraitsCopy = [[SEGState sharedInstance].userInfo.traits mutableCopy];
+    NSMutableDictionary *traitsCopy = [traits mutableCopy];
     // if no traits were passed in, need to create.
-    if (newTraits == nil) {
-        newTraits = [[NSMutableDictionary alloc] init];
+    if (existingTraitsCopy == nil) {
+        existingTraitsCopy = [[NSMutableDictionary alloc] init];
     }
-    newTraits[@"anonymousId"] = anonId;
+    if (traitsCopy == nil) {
+        traitsCopy = [[NSMutableDictionary alloc] init];
+    }
+    traitsCopy[@"anonymousId"] = anonId;
     if (userId != nil) {
-        newTraits[@"userId"] = userId;
+        traitsCopy[@"userId"] = userId;
         [SEGState sharedInstance].userInfo.userId = userId;
     }
     // merge w/ existing traits and set them.
-    NSDictionary *existingTraits = [SEGState sharedInstance].userInfo.traits;
-    [newTraits addEntriesFromDictionary:existingTraits];
-    [SEGState sharedInstance].userInfo.traits = newTraits;
+    [existingTraitsCopy addEntriesFromDictionary:traits];
+    [SEGState sharedInstance].userInfo.traits = existingTraitsCopy;
 
     [self run:SEGEventTypeIdentify payload:
                                        [[SEGIdentifyPayload alloc] initWithUserId:userId
                                                                       anonymousId:anonId
-                                                                           traits:SEGCoerceDictionary(newTraits)
+                                                                           traits:SEGCoerceDictionary(existingTraitsCopy)
                                                                           context:SEGCoerceDictionary([options objectForKey:@"context"])
                                                                      integrations:[options objectForKey:@"integrations"]]];
 }