Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSData GZIP category conflict #584

Closed
milancermak opened this issue Aug 5, 2016 · 4 comments
Closed

NSData GZIP category conflict #584

milancermak opened this issue Aug 5, 2016 · 4 comments

Comments

@milancermak
Copy link

The recent addition or NSData+GZIP causes a conflict with another library I use (KSCrash) in my project, because it also defines the same category.

I'm not a Cocoapods expert, but I think this could be prevented if the podspec of this library would list public headers correctly. I'm guessing everything inside Internal/ should not be public anyway.

@f2prateek
Copy link
Contributor

This was fixed https://github.com/segmentio/analytics-ios/blob/master/Analytics/Classes/Internal/NSData%2BGZIP.m#L54, it will be part of the next release.

Some of the internal classes are used by integrations (which are built outside of this library) which is why we can't mark them as private just yet.

@milancermak
Copy link
Author

It's not a conflict in method names, sorry for the incorrect description of the isuse.

The problem is that the other library also has a Gzip category on NSData, so when it tries to call for example gunzippedWithError:, the compiler looks into the Analytics' GZip category and doesn't find it.

The error I get is No visible @interface for 'NSData' declares the selector 'gunzippedWithError:'.

@f2prateek
Copy link
Contributor

I see - so I think renaming our extension to NSData+SEGGZip should work for now.

@milancermak
Copy link
Author

Yeah, that should be fine too.

f2prateek added a commit that referenced this issue Aug 5, 2016
f2prateek added a commit that referenced this issue Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants