-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NSData GZIP category conflict #584
Comments
This was fixed https://github.com/segmentio/analytics-ios/blob/master/Analytics/Classes/Internal/NSData%2BGZIP.m#L54, it will be part of the next release. Some of the internal classes are used by integrations (which are built outside of this library) which is why we can't mark them as private just yet. |
It's not a conflict in method names, sorry for the incorrect description of the isuse. The problem is that the other library also has a Gzip category on NSData, so when it tries to call for example The error I get is |
I see - so I think renaming our extension to |
Yeah, that should be fine too. |
The recent addition or NSData+GZIP causes a conflict with another library I use (KSCrash) in my project, because it also defines the same category.
I'm not a Cocoapods expert, but I think this could be prevented if the podspec of this library would list public headers correctly. I'm guessing everything inside
Internal/
should not be public anyway.The text was updated successfully, but these errors were encountered: