Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set anonymousId removed in 3.6.0 #753

Closed
jonah-williams opened this issue Mar 2, 2018 · 2 comments · Fixed by #799
Closed

Ability to set anonymousId removed in 3.6.0 #753

jonah-williams opened this issue Mar 2, 2018 · 2 comments · Fixed by #799

Comments

@jonah-williams
Copy link

I stumbled across an unexpected change in behavior after upgrading across 3.6.0.

In 3.5.7...3.6.0#diff-90ee8062efa95f661137bf2685fd0256L271 we can see that identify started constructing a SEGIdentifyPayload with a nil anonymousId (and that remains true today in https://github.com/segmentio/analytics-ios/blob/master/Analytics/Classes/SEGAnalytics.m#L203) We used to be able to specify an anonymous id in the options argument.

https://github.com/segmentio/analytics-ios/blob/master/Analytics/Classes/Integrations/SEGIntegrationsManager.m#L155 appears to retain some of this behavior which checks SEGIdentifyPayload.options but that can now only ever contain context and integrations keys via https://github.com/segmentio/analytics-ios/blob/master/Analytics/Classes/Integrations/SEGIntegrationsManager.m#L526

I had found the option to specify an anonymous id useful because it allowed me to keep identifiers for crash logging and analytics in sync so I could correlate them as needed. In my case I can switch to allowing Segment to be the authority over my anonymous ids but maybe there should be some option to explicitly set this value, either via identify or otherwise?

@f2prateek
Copy link
Contributor

Ah yep, this looks like a bug as part of the middleware changes. I think the fix should be to move that logic from SEGIntegrationsManager upto `SEGAnalytics.

@f2prateek
Copy link
Contributor

I don't have an ETA, but I've triaged the issue internally in our JIRA https://segment.atlassian.net/browse/LIB-266

@f2prateek f2prateek changed the title Was the option to specify an anonymous id during identify intentionally removed in 3.6.0? Ability to set anonymousId removed in 3.6.0 Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants