Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make setting the anonymousId public #790

Closed

Conversation

gabek
Copy link

@gabek gabek commented Sep 25, 2018

I'm sure there's a reason why saving the anonymousId isn't made public, but I'm not sure what it is, so I'm submitting this PR if, for nothing else, to re-spur the conversation.

What does this PR do?
Allows setting of the anonymousId in the integrations manager.

How should this be manually tested?

segment.getAnonymousId() -> "abc123"
segment.setAnonymousId("test123")
segment.getAnonymousId() -> "test123"

Validate in the Segment debugger that the correct anonymous Id comes through.

What are the relevant tickets?
#753

Questions:

  • Does the docs need an update? Yes
  • Are there any security concerns? I'm not aware of any,
  • Do we need to update engineering / success? shrug

@gabek gabek force-pushed the gek/support-anonymousid-override branch from 22b4f3c to 2186c21 Compare September 25, 2018 23:23
@f2prateek
Copy link
Contributor

Rather than adding a new method - I think we would want to do what #485 did, and fix the regression in #753.

What happened here was:

  1. We merged [Identify] Make Anonymous ID customisable. #485 which allows you to set a custom anonymousId
  2. We made some changes that broke the behaviour added in [Identify] Make Anonymous ID customisable. #485 (described in Ability to set anonymousId removed in 3.6.0 #753).

@fathyb
Copy link
Contributor

fathyb commented Dec 13, 2018

Fixed with #799

@fathyb fathyb closed this Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants