Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports some fixes from 3.8 series to 3.7 series #867

Merged
merged 8 commits into from
Feb 21, 2020

Conversation

bsneed
Copy link
Contributor

@bsneed bsneed commented Feb 21, 2020

  • Uses previously cached settings if unable to retrieve from server.
  • Settings were being cached already, just not used.
  • If no settings are present (server or cached), fallback to the barebones config.
  • Fixed LIB-1698; Differences observed in how ios/android pass userId/anonId in traits.
  • Pulled in fix for GCD dependency issue.

@codecov-io
Copy link

codecov-io commented Feb 21, 2020

Codecov Report

Merging #867 into releases/3.7.1 will increase coverage by 0.82%.
The diff coverage is 77.77%.

@@                Coverage Diff                @@
##           releases/3.7.1    #867      +/-   ##
=================================================
+ Coverage           86.28%   87.1%   +0.82%     
=================================================
  Files                  52      52              
  Lines                2793    3002     +209     
=================================================
+ Hits                 2410    2615     +205     
- Misses                383     387       +4

Copy link
Contributor

@danieljackins danieljackins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 LGTM

@bsneed bsneed merged commit 0ed64b8 into releases/3.7.1 Feb 21, 2020
@bsneed bsneed deleted the bsneed/releases/3.7.1 branch February 21, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants