Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a method to put device tokens which are utilized by some destinations (e.g. Customer.io). The Segment Android SDK offers the same functionality. Setting device tokens (obtained from Firebase Cloud Messaging SDK) enables Customer.io to track devices via Segment which enables their push notification feature.
How should this be manually tested?
Call
[SEGAnalytics.sharedAnalytics putDeviceToken:@"i-am-a-device-token"]
and check in Segment’s event debugger if new events contain thetoken
key within theircontext/device
dictionary.Any background context you want to provide?
We are developing in React Native and are using Firebase Cloud Messaging (via React Native Firebase). We want to use Customer.io to send out push notifications, so we are working on a pull request for the Segment React Native SDK to add functionality which is required to make this happen. Before we can continue our work we need a way to set a FCM device token in iOS – hence this pull request.
What are the relevant tickets?
#869
Questions:
I added comments, but the Segment website (Analytics for iOS) might also need one.
I don't think so.
Maybe?