Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ability for us and customers to make custom types serializable … #940

Merged
merged 2 commits into from
Sep 9, 2020
Merged

Added ability for us and customers to make custom types serializable … #940

merged 2 commits into from
Sep 9, 2020

Conversation

bsneed
Copy link
Contributor

@bsneed bsneed commented Sep 9, 2020

…to segment

  • Adds SEGSerializable protocol to allow types to be made serializable to Segment.
  • Adds SEGSerializable conformance for NSDate and NSURL.

prayansh
prayansh reviewed Sep 9, 2020
View reviewed changes
AnalyticsTests/SerializationTests.m
@@ -56,20 +72,37 @@ - (void)testDeepCopyAndConformance {
XCTAssertThrows([nonserializable serializableDeepCopy]);
}

- (void)testDateIssue {
- (void)testSEGSerialization {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hype 🔥

migs647
migs647 reviewed Sep 9, 2020
View reviewed changes
Analytics/Classes/SEGAnalyticsUtils.h
@@ -2,9 +2,23 @@

NS_ASSUME_NONNULL_BEGIN

// Logging
#pragma mark - Logging
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

migs647
migs647 approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@migs647 migs647 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsneed bsneed merged commit 2cb6864 into master Sep 9, 2020
@bsneed bsneed deleted the bsneed/serialization branch September 9, 2020 22:36
@bsneed bsneed mentioned this pull request Sep 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prayansh prayansh prayansh left review comments

@migs647 migs647 migs647 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bsneed @migs647 @prayansh