Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift Rename #942

Merged
merged 19 commits into from
Sep 21, 2020
Merged

Swift Rename #942

merged 19 commits into from
Sep 21, 2020

Conversation

bsneed
Copy link
Contributor

@bsneed bsneed commented Sep 17, 2020

  • Renames module to Segment from Analytics
  • Removes all existing pod dependencies.
  • Updates tests to run on macOS, iOS, tvOS in CI.
  • Fixes some macOS-related code paths.

migs647
migs647 reviewed Sep 17, 2020
View reviewed changes
SegmentTests/Utils/TestUtils.swift
}


/* TODO: Needs Nocilla
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nocilla DIAF

migs647
migs647 approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@migs647 migs647 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small comments, otherwise LGTM

@bsneed bsneed merged commit 239c96e into master Sep 21, 2020
@af-fess af-fess mentioned this pull request Oct 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@migs647 migs647 migs647 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsneed @migs647