Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix configuration setting for edgefn #950

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Fix configuration setting for edgefn #950

merged 1 commit into from
Oct 15, 2020

Conversation

bsneed
Copy link
Contributor

@bsneed bsneed commented Oct 15, 2020

  • Removes configuration shimmy from SEGAnalytics and puts it in SEGAnalyticsConfiguration where it belongs.
  • Stops trying to double wrap options in array.

migs647
migs647 approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@migs647 migs647 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where the tests

LGTM

@bsneed bsneed merged commit 3b66f47 into master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@migs647 migs647 migs647 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsneed @migs647