Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Residency Changes #973

Merged
merged 3 commits into from
Dec 10, 2020
Merged

Data Residency Changes #973

merged 3 commits into from
Dec 10, 2020

Conversation

bsneed
Copy link
Contributor

@bsneed bsneed commented Dec 9, 2020

  • Adds support for data residency.
  • New configuration constructor option to allow for a default API host to be supplied.
  • New configuration property, apiHost to retrieve the host in use.
  • ApiHost can be picked up from /settings endpoint and stored for future requests.
  • Fixed issue where defaultSettings might be read and/or stored incorrectly.
  • Fixed some project warnings in Xcode 12

@bsneed
Copy link
Contributor Author

bsneed commented Dec 9, 2020

This also fixes #972

@bsneed bsneed mentioned this pull request Dec 9, 2020
Closed
migs647
migs647 approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@migs647 migs647 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@bsneed bsneed merged commit fa0d3c5 into master Dec 10, 2020
@bsneed bsneed deleted the bsneed/data-residency branch December 10, 2020 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@migs647 migs647 migs647 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsneed @migs647