-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Including sentAt in the Batch body of the HTTP request forces the use of a segment server computed timestamp #340
Comments
Instead of removing it completely you could allow users of the library to set the sentAt timestamp so that we can set it to null if we're doing a historical import. |
@pooyaj It needs to be accessible from the client library. I need to be able to do builder.sentAt(null). |
@sromocki just a clarification on the changes:
if you don't have an |
Is it possible to not include the sentAt() in the Batch body as this then forces all requests to use Segment's calculated timestamp versus the client provided timestamp if they try and set one. Usually when a client sets a timestamp its for historical reasons and so the client provided timestamp should be the single source of truth without any calculations around clock skew.
The text was updated successfully, but these errors were encountered: