Add option to sentAt field to be null #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…date on sentAt field or use a null value
wenxi-zeng
requested changes
May 5, 2022
There was a problem hiding this comment.
the changes does not address the issue, since Batch.create() is only used internally to create a batch.
you'll need to do the following:
- in
Messageadd a new nullable fieldsentAt - in
MessageBuilderadd a new fieldsentAtand make changes accordingly. you can takeuserIdas an example for what needs to be done - in
MessageBuilder.realBuildadd a new parametersentAtand make changes accordingly. - discard all your changes in
Batch. increatemethod do the following
if any message in batch has `sentAt` not null
use that value to create batch
otherwise
use `new Date()` to create batchnow the users can use builder.sentAt() to modify the value
wenxi-zeng
reviewed
May 5, 2022
| } | ||
|
|
||
| public abstract List<Message> batch(); | ||
|
|
||
| @Nullable |
| @@ -26,6 +28,22 @@ public void create(TestUtils.MessageBuilderFactory factory) { | |||
| assertThat(batch.context()).isEqualTo(context); | |||
| } | |||
|
|
|||
| @Test | |||
| public void createWithSentAt(TestUtils.MessageBuilderFactory factory) throws ParseException { | |||
There was a problem hiding this comment.
better to have another test with messages has sentAt as nulls, so we have both paths covered.
pooyaj
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Override method create on Batch class to lend to user define his own date on sentAt field or use a null value.
Issue #340