Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for TLS version error (protocol not supported error) #304

Merged
merged 2 commits into from
Jan 5, 2022

Conversation

jorgen25
Copy link
Contributor

@jorgen25 jorgen25 commented Dec 8, 2021

Added a method to the Analytics Builder class forceTlsVersion1() - name subject to change
Usage -
        Analytics.Builder builder = Analytics.builder("someKey");
        Analytics analytics = builder.userAgent("someUserAgent")
        .client(someClient)
        .endpoint("some endpoint")
        .anotherAlreadyExistingMethod(someParam)
        .forceTlsVersion1()
        .build();

this new method forces the httpClient to be created using  ConnectionSpec of MODERN_TLS and including Tls Versions: TLS_1_0, TLS_1_1, TLS_1_2, TLS_1_3

Also added a simple test case

Jorge Rodriguera added 2 commits December 8, 2021 12:15
    Added a method to the Analytics Builder class forceTlsVersion1() - name subject to change
    Usage -
            Analytics.Builder builder = Analytics.builder("someKey");
            Analytics analytics = builder.userAgent("someUserAgent")
            .client(someClient)
            .endpoint("some endpoint")
            .anotherAlreadyExistingMethod(someParam)
            .forceTlsVersion1()
            .build();

    this new method forces the httpClient to be created using  ConnectionSpec of MODERN_TLS and including Tls Versions: TLS_1_0, TLS_1_1, TLS_1_2, TLS_1_3

    Also added a simple test case
@pooyaj pooyaj merged commit a9810cc into segmentio:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants