fix: AnalyticsClient Looper won't start if isShutdown is true #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgen25
suggested changes
Jan 5, 2022
|
Sure. @jorgen25 I need to make a few changes to test cases about the mock. |
Used @SPY for mocking LinkedBlockingQueue changed from initMocks(deprecated) to openMocks
Codecov Report
@@ Coverage Diff @@
## master #305 +/- ##
==========================================
- Coverage 68.87% 68.76% -0.12%
==========================================
Files 31 31
Lines 890 890
Branches 148 149 +1
==========================================
- Hits 613 612 -1
Misses 245 245
- Partials 32 33 +1
Continue to review full report at Codecov.
|
|
@jorgen25 Tests have passed now. They were mainly formatting issues by spotless. |
jorgen25
added a commit
to North-Two-Five/analytics-java
that referenced
this pull request
Feb 10, 2022
|
Replaced by PR #323 Thank you |
1abhishekpandey
added a commit
to rudderlabs/rudder-sdk-java
that referenced
this pull request
Jan 3, 2023
* Bump spotless-maven-plugin from 2.14.0 to 2.17.3 Bumps [spotless-maven-plugin](https://github.com/diffplug/spotless) from 2.14.0 to 2.17.3. - [Release notes](https://github.com/diffplug/spotless/releases) - [Changelog](https://github.com/diffplug/spotless/blob/main/CHANGES.md) - [Commits](diffplug/spotless@lib/2.14.0...maven/2.17.3) --- updated-dependencies: - dependency-name: com.diffplug.spotless:spotless-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Initial PR intended as a draft please review approach and let me know if I should go ahead with implementing changes * Modified logic for size check for each message before adding to queue, also checks size for the batch creation and test cases I have a bunch of comments that i will remove before merge if PR gets approved. * ran mvn spotless:apply to fix circlet errors * Test case succeeds locally, forcing test to wait to guarantee interaction happens * fix circlet code violation with mvn spotless apply * forced wait to guarantee interaction in test * Bump okhttp from 4.3.0 to 4.9.3 Bumps [okhttp](https://github.com/square/okhttp) from 4.3.0 to 4.9.3. - [Release notes](https://github.com/square/okhttp/releases) - [Changelog](https://github.com/square/okhttp/blob/master/CHANGELOG.md) - [Commits](square/okhttp@parent-4.3.0...parent-4.9.3) --- updated-dependencies: - dependency-name: com.squareup.okhttp3:okhttp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bugfix for TLS version error (protocol not supported error) Added a method to the Analytics Builder class forceTlsVersion1() - name subject to change Usage - Analytics.Builder builder = Analytics.builder("someKey"); Analytics analytics = builder.userAgent("someUserAgent") .client(someClient) .endpoint("some endpoint") .anotherAlreadyExistingMethod(someParam) .forceTlsVersion1() .build(); this new method forces the httpClient to be created using ConnectionSpec of MODERN_TLS and including Tls Versions: TLS_1_0, TLS_1_1, TLS_1_2, TLS_1_3 Also added a simple test case * run maven spotless:apply * Bump spring-boot-autoconfigure from 2.5.5 to 2.6.2 Bumps [spring-boot-autoconfigure](https://github.com/spring-projects/spring-boot) from 2.5.5 to 2.6.2. - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v2.5.5...v2.6.2) --- updated-dependencies: - dependency-name: org.springframework.boot:spring-boot-autoconfigure dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump auto.version from 1.8.2 to 1.9 Bumps `auto.version` from 1.8.2 to 1.9. Updates `auto-value` from 1.8.2 to 1.9 - [Release notes](https://github.com/google/auto/releases) - [Commits](google/auto@auto-value-1.8.2...auto-value-1.9) Updates `auto-value-annotations` from 1.8.2 to 1.9 - [Release notes](https://github.com/google/auto/releases) - [Commits](google/auto@auto-value-1.8.2...auto-value-1.9) --- updated-dependencies: - dependency-name: com.google.auto.value:auto-value dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: com.google.auto.value:auto-value-annotations dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump logging-interceptor from 4.9.1 to 4.9.3 Bumps [logging-interceptor](https://github.com/square/okhttp) from 4.9.1 to 4.9.3. - [Release notes](https://github.com/square/okhttp/releases) - [Changelog](https://github.com/square/okhttp/blob/master/CHANGELOG.md) - [Commits](square/okhttp@parent-4.9.1...parent-4.9.3) --- updated-dependencies: - dependency-name: com.squareup.okhttp3:logging-interceptor dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump maven-compiler-plugin from 3.8.1 to 3.9.0 Bumps [maven-compiler-plugin](https://github.com/apache/maven-compiler-plugin) from 3.8.1 to 3.9.0. - [Release notes](https://github.com/apache/maven-compiler-plugin/releases) - [Commits](apache/maven-compiler-plugin@maven-compiler-plugin-3.8.1...maven-compiler-plugin-3.9.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-compiler-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump kotlin.version from 1.5.31 to 1.6.10 Bumps `kotlin.version` from 1.5.31 to 1.6.10. Updates `kotlin-stdlib` from 1.5.31 to 1.6.10 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v1.5.31...v1.6.10) Updates `kotlin-maven-plugin` from 1.5.31 to 1.6.10 --- updated-dependencies: - dependency-name: org.jetbrains.kotlin:kotlin-stdlib dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.jetbrains.kotlin:kotlin-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump assertj-core from 3.21.0 to 3.22.0 Bumps [assertj-core](https://github.com/assertj/assertj-core) from 3.21.0 to 3.22.0. - [Release notes](https://github.com/assertj/assertj-core/releases) - [Commits](assertj/assertj@assertj-core-3.21.0...assertj-core-3.22.0) --- updated-dependencies: - dependency-name: org.assertj:assertj-core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump spring-boot-autoconfigure from 2.6.2 to 2.6.3 Bumps [spring-boot-autoconfigure](https://github.com/spring-projects/spring-boot) from 2.6.2 to 2.6.3. - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v2.6.2...v2.6.3) --- updated-dependencies: - dependency-name: org.springframework.boot:spring-boot-autoconfigure dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump gson from 2.8.8 to 2.8.9 Bumps [gson](https://github.com/google/gson) from 2.8.8 to 2.8.9. - [Release notes](https://github.com/google/gson/releases) - [Changelog](https://github.com/google/gson/blob/master/CHANGELOG.md) - [Commits](google/gson@gson-parent-2.8.8...gson-parent-2.8.9) --- updated-dependencies: - dependency-name: com.google.code.gson:gson dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump spotless-maven-plugin from 2.17.3 to 2.20.0 Bumps [spotless-maven-plugin](https://github.com/diffplug/spotless) from 2.17.3 to 2.20.0. - [Release notes](https://github.com/diffplug/spotless/releases) - [Changelog](https://github.com/diffplug/spotless/blob/main/CHANGES.md) - [Commits](diffplug/spotless@maven/2.17.3...lib/2.20.0) --- updated-dependencies: - dependency-name: com.diffplug.spotless:spotless-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump mockito-core from 3.12.4 to 4.3.1 Bumps [mockito-core](https://github.com/mockito/mockito) from 3.12.4 to 4.3.1. - [Release notes](https://github.com/mockito/mockito/releases) - [Commits](mockito/mockito@v3.12.4...v4.3.1) --- updated-dependencies: - dependency-name: org.mockito:mockito-core dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * based on PR: segmentio#316 fixed compile errors: mockito version is upgraded so some methods are not named the same example: verifyZeroInteractions became verifyNoInteractions * run mvn:spotless apply * removed inner loop,sequence counter and modified test cases * ran mvn spotless apply` * waiting to confirm interaction on mock * removed hashmap from loop * ran mvn spotless * Creating PR from segmentio#305 * Bump gson from 2.8.9 to 2.9.0 Bumps [gson](https://github.com/google/gson) from 2.8.9 to 2.9.0. - [Release notes](https://github.com/google/gson/releases) - [Changelog](https://github.com/google/gson/blob/master/CHANGELOG.md) - [Commits](google/gson@gson-parent-2.8.9...gson-parent-2.9.0) --- updated-dependencies: - dependency-name: com.google.code.gson:gson dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump spotless-maven-plugin from 2.20.0 to 2.20.2 Bumps [spotless-maven-plugin](https://github.com/diffplug/spotless) from 2.20.0 to 2.20.2. - [Release notes](https://github.com/diffplug/spotless/releases) - [Changelog](https://github.com/diffplug/spotless/blob/main/CHANGES.md) - [Commits](diffplug/spotless@lib/2.20.0...lib/2.20.2) --- updated-dependencies: - dependency-name: com.diffplug.spotless:spotless-maven-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump maven-compiler-plugin from 3.9.0 to 3.10.0 Bumps [maven-compiler-plugin](https://github.com/apache/maven-compiler-plugin) from 3.9.0 to 3.10.0. - [Release notes](https://github.com/apache/maven-compiler-plugin/releases) - [Commits](apache/maven-compiler-plugin@maven-compiler-plugin-3.9.0...maven-compiler-plugin-3.10.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-compiler-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * ran mvn spotless:apply * Bump spotless-maven-plugin from 2.20.2 to 2.21.0 Bumps [spotless-maven-plugin](https://github.com/diffplug/spotless) from 2.20.2 to 2.21.0. - [Release notes](https://github.com/diffplug/spotless/releases) - [Changelog](https://github.com/diffplug/spotless/blob/main/CHANGES.md) - [Commits](diffplug/spotless@lib/2.20.2...lib/2.21.0) --- updated-dependencies: - dependency-name: com.diffplug.spotless:spotless-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump spring-boot-autoconfigure from 2.6.3 to 2.6.4 Bumps [spring-boot-autoconfigure](https://github.com/spring-projects/spring-boot) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: org.springframework.boot:spring-boot-autoconfigure dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump guava from 31.0-jre to 31.1-jre Bumps [guava](https://github.com/google/guava) from 31.0-jre to 31.1-jre. - [Release notes](https://github.com/google/guava/releases) - [Commits](https://github.com/google/guava/commits) --- updated-dependencies: - dependency-name: com.google.guava:guava dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Bump maven-compiler-plugin from 3.10.0 to 3.10.1 Bumps [maven-compiler-plugin](https://github.com/apache/maven-compiler-plugin) from 3.10.0 to 3.10.1. - [Release notes](https://github.com/apache/maven-compiler-plugin/releases) - [Commits](apache/maven-compiler-plugin@maven-compiler-plugin-3.10.0...maven-compiler-plugin-3.10.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-compiler-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump mockito-core from 4.3.1 to 4.4.0 Bumps [mockito-core](https://github.com/mockito/mockito) from 4.3.1 to 4.4.0. - [Release notes](https://github.com/mockito/mockito/releases) - [Commits](mockito/mockito@v4.3.1...v4.4.0) --- updated-dependencies: - dependency-name: org.mockito:mockito-core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Removed the line for failure callback method * Bump spring-boot-autoconfigure from 2.6.4 to 2.6.5 Bumps [spring-boot-autoconfigure](https://github.com/spring-projects/spring-boot) from 2.6.4 to 2.6.5. - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v2.6.4...v2.6.5) --- updated-dependencies: - dependency-name: org.springframework.boot:spring-boot-autoconfigure dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update pom.xml * fix pom file * [maven-release-plugin] prepare release analytics-parent-3.2.0 * [maven-release-plugin] prepare for next development iteration * Bump spotless-maven-plugin from 2.21.0 to 2.22.0 Bumps [spotless-maven-plugin](https://github.com/diffplug/spotless) from 2.21.0 to 2.22.0. - [Release notes](https://github.com/diffplug/spotless/releases) - [Changelog](https://github.com/diffplug/spotless/blob/main/CHANGES.md) - [Commits](diffplug/spotless@lib/2.21.0...lib/2.22.0) --- updated-dependencies: - dependency-name: com.diffplug.spotless:spotless-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * removed wildcards * run spotless * Bump spotless-maven-plugin from 2.22.0 to 2.22.1 Bumps [spotless-maven-plugin](https://github.com/diffplug/spotless) from 2.22.0 to 2.22.1. - [Release notes](https://github.com/diffplug/spotless/releases) - [Changelog](https://github.com/diffplug/spotless/blob/main/CHANGES.md) - [Commits](diffplug/spotless@lib/2.22.0...lib/2.22.1) --- updated-dependencies: - dependency-name: com.diffplug.spotless:spotless-maven-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump kotlin.version from 1.6.10 to 1.6.21 Bumps `kotlin.version` from 1.6.10 to 1.6.21. Updates `kotlin-stdlib` from 1.6.10 to 1.6.21 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/v1.6.21/ChangeLog.md) - [Commits](JetBrains/kotlin@v1.6.10...v1.6.21) Updates `kotlin-maven-plugin` from 1.6.10 to 1.6.21 --- updated-dependencies: - dependency-name: org.jetbrains.kotlin:kotlin-stdlib dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.jetbrains.kotlin:kotlin-maven-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Override method create on Batch class to lend to user define his own date on sentAt field or use a null value * Modify MessageBuilder to lend set sentAt value * Apply spotless library to organize the code * Changed order for params from all AutoValue classes * Added value sentAt param on IdentifyMessage * Remove Nullable from sentAt om Batch, add Test for sentAt null * Add throw interrupted exception when event exceeds 32kb to stop Thread * Update the history on CHANGELOG.md to 3.3 version * Change line structure from exception on AnalyticsClient * Bump assertj-core from 3.22.0 to 3.23.1 Bumps [assertj-core](https://github.com/assertj/assertj-core) from 3.22.0 to 3.23.1. - [Release notes](https://github.com/assertj/assertj-core/releases) - [Commits](assertj/assertj@assertj-core-3.22.0...assertj-core-3.23.1) --- updated-dependencies: - dependency-name: org.assertj:assertj-core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump logging-interceptor from 4.9.3 to 4.10.0 Bumps [logging-interceptor](https://github.com/square/okhttp) from 4.9.3 to 4.10.0. - [Release notes](https://github.com/square/okhttp/releases) - [Changelog](https://github.com/square/okhttp/blob/master/CHANGELOG.md) - [Commits](square/okhttp@parent-4.9.3...parent-4.10.0) --- updated-dependencies: - dependency-name: com.squareup.okhttp3:logging-interceptor dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Add test for semerujdk11 * Change validation on BatchTest on createWithSentAtNull * Bump mockito-core from 4.4.0 to 4.6.1 Bumps [mockito-core](https://github.com/mockito/mockito) from 4.4.0 to 4.6.1. - [Release notes](https://github.com/mockito/mockito/releases) - [Commits](mockito/mockito@v4.4.0...v4.6.1) --- updated-dependencies: - dependency-name: org.mockito:mockito-core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump spotless-maven-plugin from 2.22.1 to 2.23.0 Bump okhttp from 4.9.3 to 4.10.0 Bump kotlin.version from 1.6.21 to 1.7.0 Bump spring-boot-autoconfigure from 2.6.6 to 2.7.1 Bump mockito-core from 4.4.0 to 4.6.1 * Update dependabot library and remove semeru image test for circleci * Update version from gson and spotless-maven-pligun * [maven-release-plugin] prepare release analytics-parent-3.3.0 * [maven-release-plugin] prepare for next development iteration * [maven-release-plugin] prepare release analytics-parent-3.3.1 * [maven-release-plugin] prepare for next development iteration * Update CHANGELOG.md * in dev projects must use -SNAPSHOT or depends on -SNAPSHOT parent (segmentio#386) * in dev projects must use -SNAPSHOT or depends on -SNAPSHOT parent Signed-off-by: Olivier Lamy <olamy@apache.org> * touch to trigger a build Signed-off-by: Olivier Lamy <olamy@apache.org> Signed-off-by: Olivier Lamy <olamy@apache.org> * Bump spring-boot-autoconfigure from 2.7.2 to 2.7.4 (segmentio#382) Bumps [spring-boot-autoconfigure](https://github.com/spring-projects/spring-boot) from 2.7.2 to 2.7.4. - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v2.7.2...v2.7.4) --- updated-dependencies: - dependency-name: org.springframework.boot:spring-boot-autoconfigure dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump mockito-core from 4.6.1 to 4.8.0 (segmentio#380) Bumps [mockito-core](https://github.com/mockito/mockito) from 4.6.1 to 4.8.0. - [Release notes](https://github.com/mockito/mockito/releases) - [Commits](mockito/mockito@v4.6.1...v4.8.0) --- updated-dependencies: - dependency-name: org.mockito:mockito-core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Call upload URL using Retrofit's @url annotation (segmentio#391) * call upload URL using Retrofit's @url annotation * fix formatting Co-authored-by: David Menear <dmenear@users.noreply.github.com> * Bump mockito-core from 4.8.0 to 4.8.1 (segmentio#390) Bumps [mockito-core](https://github.com/mockito/mockito) from 4.8.0 to 4.8.1. - [Release notes](https://github.com/mockito/mockito/releases) - [Commits](mockito/mockito@v4.8.0...v4.8.1) --- updated-dependencies: - dependency-name: org.mockito:mockito-core dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update libraries to fix test (segmentio#392) * Bump spring-boot-autoconfigure from 2.7.4 to 2.7.5 (segmentio#389) Bumps [spring-boot-autoconfigure](https://github.com/spring-projects/spring-boot) from 2.7.4 to 2.7.5. - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v2.7.4...v2.7.5) --- updated-dependencies: - dependency-name: org.springframework.boot:spring-boot-autoconfigure dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Merge remote-tracking branch 'base/master' into feat/latestPull * chore: remove unused code * chore: improve comment * fix: migrate uploading task from `UploadResponse` to `ResponseBody` UploadRespone is having issue while uploading the payload to the RudderServer, hence reverted back the merge changes (which is already being used in the RudderJava SDK) * feat: add `context` at each message level * chore: bump version to `2.1.0` * chore: update README.md and refactor code * refactor: change linkedHashMap to HashMap in Context object * test: fix context test failure * feat: add support for `channel` object in individual payload (#41) Now `channel = server` will be added along with each message payload. * feat!: bundle the `gzip` support inside the core SDK (#42) * feat!: bundle the `gzip` support inside the core SDK Now, GZIP will be enabled by default and have also introduced an API to toggle the GZIP default value, called `enableGZIP`. If user continues to use the `client` API to pass the OkHttpClient then `enableGZIP` API value will not be taken into consideration. BREAKING CHANGE: Now user who are using the Java SDK, with self-hosted dataPlane and without their own custom `OkHttpClient` (passed using `client` API)` needs to make sure that their server supports GZIP i.e., their server version is above 1.4, else they could either use `enableGZIP` API or pass a custom OkHttpClient instance without the GZIP interceptor. * refactor: change API name from `enableGZIP` to `setGZIP` * ci: add CI feature (#43) * ci: add build and quality check * ci: add `PR` title check * ci: add slack notify check * ci: implement jacoco report generator, sonarqube, pmd and checkstyle lint check * ci: skip CI for sample app * ci: add `build check` and `coverage` badge to readme file * ci: fix PMD and checkstyle lint plugin version * test: fix the MSG_MAX_CREATE_SIZE in AnalyticsClient Decrease the size by 1, otherwise the test was failing * ci: add suppression rule for checkstyle * chore: add feat/latestPull to test the working of build and quality check Once test completes, revert the change. * chore: disable badge support Once test completes, revert the change. * ci: add `Setup` process for `lint` action * ci: set `sonar.java.skipUnchanged` to false To try to remove optimise this log message: `[INFO] The Java analyzer is running in a context where unchanged files can be skipped. Full analysis is performed for changed files, optimized analysis for unchanged files.` * ci: set `source` and `test` directory for sonar analysis * ci: set the `exclusion` property for sonar * ci: set `main` and `test` property for sonar * ci: comment source and test path for * chore: try different sonar command * ci: add jacoco version in pom * chore: revert sonar command * chore: trigger CI * chore: remove comment * ci: retry badge action It was producing error earlier, retry now to understand the issue. * ci: change the name of the action to `Jacoco Badge generator` * ci: try different action to push the Jacoco report badge * Revert "ci: try different action to push the Jacoco report badge" This reverts commit 8f50972. * ci: try different action to push the Jacoco report badge * ci: try different action to push the Jacoco report badge * ci: disable Jacoco badge generator Having issues (because of EndBug/add-and-commit@v9.1.1) while uploading back the badge to the git branch, hence disabled it. Error log: `Error: Error: fatal: You are not currently on a branch. To push the history leading to the current (detached HEAD) state now, use git push origin HEAD:<name-of-remote-branch>` * ci: add `Notion PR sync` action * Revert: remove `feat/latestPull` branch from the action. This reverts commit: 4d7651f. As the result of the CI is satisfactory, hence removing the `feat/latestPull`. This will also disable the CI pipeline for this PR. * fix: change project name to Java SDK in slack-notify * ci: remove slack-notify This is not needed as part of the CI. * ci(lint): upload lint result to sonarqube Move the lint to the same job so that lint result gets generated and uploaded to sonarqube * test(AnalyticsClientTest): fix MSG_MAX_CREATE_SIZE size limit After merging all the PRs, test started failing due to channel=server feature. Hence, decreased the size of the message. * Revert "chore: bump version to `2.1.0`" This reverts commit 7c121d6. * chore: bump version to `3.0.0` * test(AnalyticsClientTest): fix MSG_MAX_CREATE_SIZE size limit * feat: introduce `setDataPlaneUrl` and mark `endPoint` as deprecated (#45) * feat: introduce `setDataPlaneUrl` and mark `endPoint` as deprecated To have uniform behaviour across SDKs, we've decided to mark `endPoint` API as deprecated and replace it with `setDataPlaneUrl` API. In future versions, we'll remove endPoint API. * refactor: optimise endpoint API logic * doc: update changelog * fix: added tier blocking sample code (#44) * fix: added tier blocking sample code * fix: tier blocking flush arrival fix * chore: update blocking flush logic Now there will be a single phaser to manage the registered parties, and it will handle the max limit (of Phaser) as well. Co-authored-by: Abhishek Pandey <64667840+1abhishekpandey@users.noreply.github.com> * doc: update changelog * feat: add getter method for dataPlaneUrl (#46) * doc: update readme * chore(analytics-cli): add setDataPlaneUrl while SDK init * doc: update readme * chore(analytics-cli): add setDataPlaneUrl while SDK init Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Olivier Lamy <olamy@apache.org> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Pooya Jaferian <pooya.j@gmail.com> Co-authored-by: Jorge Rodriguera <jrodrigueraleo@expediagroup.com> Co-authored-by: jorgen25 <jorge@team.northtwofive.com> Co-authored-by: Shane L. Duvall <shane@northtwofive.com> Co-authored-by: “Edson <edson@alcatrazstudios.com> Co-authored-by: Edson Amaya <edsonjab@gmail.com> Co-authored-by: Olivier Lamy <olamy@apache.org> Co-authored-by: David Menear <davidlmenear@gmail.com> Co-authored-by: David Menear <dmenear@users.noreply.github.com> Co-authored-by: Edson Amaya <edson.amaya.dev@gmail.com> Co-authored-by: Debanjan Chatterjee <debanjanchatterjee99@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AnalyticsClient was starting a looper even if isShutdown was true when initialising.
In that case messages submitted to Analytics were flushed even if AnalyticsClient was initialised with isShutdown as true.