Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change method static to public to create a GSON instance #400

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Change method static to public to create a GSON instance #400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions analytics/src/main/java/com/segment/analytics/internal/AnalyticsClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public static AnalyticsClient create(
new AtomicBoolean(false));
}

AnalyticsClient(
public AnalyticsClient(
BlockingQueue<Message> messageQueue,
HttpUrl uploadUrl,
SegmentService service,
Expand Down Expand Up @@ -134,11 +134,11 @@ public void run() {
}

/**
* Creating GSON object everytime we check the size seems costly, create one static instance
* Creating GSON object everytime we check the size seems costly
*
* @return static gson instance
* @return gson instance
*/
public static Gson getGsonInstance() {
public Gson getGsonInstance() {
if (gsonInstance == null) {
gsonInstance = new Gson();
}
Expand Down