Fix schema filter name collision bug #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0d4e6a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
silesky
approved these changes
Feb 8, 2024
|
@danieljackins looks good but ugh, I see a weird BK error that seems unrelated to this PR. Any idea what's going on? |
I think buildkite is/was having some issues, I saw some others with the same problem |
chrisradek
reviewed
Feb 9, 2024
| @@ -472,7 +472,7 @@ describe('schema filter', () => { | |||
| expect(updateUserProfile.track).toHaveBeenCalled() | |||
| }) | |||
|
|
|||
| it('covers different names between remote plugins and integrations', async () => { | |||
| it('works when current name differs from creation name', async () => { | |||
There was a problem hiding this comment.
Can we add a test that would have failed without this fix? 2 integrations where the 2nd one's name starts with the entirety of the 1st one?
This was referenced Feb 13, 2024
Merged
This was referenced May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with integrations containing similar names (ie. Google Analytics and Google Analytics 4) having their schema filters applied incorrectly. It updates the filters to compare the schema filter name (which uses the creation name of the integration) with the creationName field in the remote plugin.
yarn changeset. Read about changesets here).