Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create global.js consent script where withOneTrust is stored in global scope #1136

Merged
merged 7 commits into from
Sep 3, 2024

Conversation

silesky
Copy link
Contributor

@silesky silesky commented Sep 3, 2024

  • add analytics-onetrust.global.js, as analytics-onetrust.js is confusing
  • update analytics-onetrust.global.js to not namespace exports under window.AnalyticsOneTrust.

Copy link

changeset-bot bot commented Sep 3, 2024

🦋 Changeset detected

Latest commit: d307820

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@segment/analytics-consent-wrapper-onetrust Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@silesky silesky changed the title fix consent webpack namespace Create global.js consent script where withOneTrust is stored in global scope Sep 3, 2024
@silesky silesky merged commit a648fdb into master Sep 3, 2024
5 checks passed
@silesky silesky deleted the fix-consent-webpack-namespace branch September 3, 2024 19:37
@github-actions github-actions bot mentioned this pull request Sep 3, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants