Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Missing Privacy Tracking and API-Types #311

Merged
merged 4 commits into from
Mar 22, 2024
Merged

[Fix] Missing Privacy Tracking and API-Types #311

merged 4 commits into from
Mar 22, 2024

Conversation

FelixHerrmann
Copy link
Contributor

@FelixHerrmann FelixHerrmann commented Mar 18, 2024

In addition to #310 I have noticed some missing informations in the privacy manifest:

  • NSPrivacyTracking: A Boolean that indicates whether your app or third-party SDK uses data for tracking as defined under the App Tracking Transparency framework. For more information, see User Privacy and Data Use.
  • NSPrivacyAccessedAPITypes: An array of dictionaries that describe the API types your app or third-party SDK accesses that have been designated as APIs that require reasons to access. For information on the keys and values to use in the dictionaries, see Describing use of required reason API.

Source: https://developer.apple.com/documentation/bundleresources/privacy_manifest_files#4284009


This PR add's those missing informations with the following considerations:

  • despite the IDFACollection plugin example the package itself is not doing any tracking
  • the UserDefaults could potentially be used in not only Apps but AppGroups due to the use of suites, e.g. here

Please double check all of that and confirm or adjust; all available UserDefault options are listed here!


This will conflict with #310 but should be easy to resolve.

Copy link
Contributor

@bsneed bsneed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; I'll make some additional changes via a separate PR. Thanks for updating this!

@bsneed bsneed merged commit 18b0cde into segmentio:main Mar 22, 2024
@FelixHerrmann FelixHerrmann deleted the fix/missing-privacy-tracking-and-api-types branch March 22, 2024 15:51
@vlvs
Copy link

vlvs commented Mar 26, 2024

How come NSPrivacyTracking is set to false even though there is a list of NSPrivacyTrackingDomains? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants