Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve startup plugin collection. #45

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Improve startup plugin collection. #45

merged 1 commit into from
Aug 19, 2021

Conversation

bsneed
Copy link
Contributor

@bsneed bsneed commented Aug 19, 2021

  • Moved required per-platform plugins to VendorSystem.
  • Refactored startup sequence to fetch from VendorSystem and then apply lifecycle stuff.

prayansh
prayansh reviewed Aug 19, 2021
View reviewed changes
Sources/Segment/Startup.swift

// setup lifecycle if desired
if configuration.values.trackApplicationLifecycleEvents {
#if os(iOS) || os(tvOS)
plugins += [iOSLifecycleMonitor(), iOSLifecycleEvents(), DeviceToken()]
plugins.append(iOSLifecycleEvents())
Copy link
Contributor

@prayansh prayansh Aug 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make more sense to provide the lifecycleEvents plugin via the vendor system as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that would add clutter in the long term if/when we have more things that fall into that bucket.

prayansh
prayansh approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@prayansh prayansh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a suggestion on providing the lifecycleEvent plugin via vendor system, to potentially remove macro code

migs647
migs647 approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@migs647 migs647 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsneed bsneed merged commit c60d6f2 into main Aug 19, 2021
@bsneed bsneed deleted the bsneed/startup-plugins branch August 19, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prayansh prayansh prayansh approved these changes

@migs647 migs647 migs647 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bsneed @migs647 @prayansh