Reduce file descriptor consumption #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
migs647
reviewed
Sep 9, 2021
| fileHandle?.seekToEndOfFile() | ||
| // prepare for the next entry | ||
| if newFile == false { | ||
| fileHandle?.write(",".data(using: .utf8)!) |
There was a problem hiding this comment.
Do we absolutely know 100% of the time this explicit will work on all platforms? Makes me uneasy.
There was a problem hiding this comment.
Why would it not work on all platforms?? It's almost identical to what it was before and tests are passing hunky dory.
There was a problem hiding this comment.
I guess it just being a comma should be okay.
migs647
reviewed
Sep 9, 2021
| assert(false, "Storage: failed to write event to \(storeFile), error: \(error)") | ||
| // write the data | ||
| fileHandle?.write(jsonData) | ||
| if #available(tvOS 13, *) { |
There was a problem hiding this comment.
Might be good to add a comment why we are doing this for 13 and above but supporting 11.
migs647
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces file descriptor usage by storing file handle rather than opening a new one with every write.