Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to destinations to match ExampleDestination #64

Merged
merged 6 commits into from
Sep 21, 2021

Conversation

migs647
Copy link
Contributor

@migs647 migs647 commented Sep 21, 2021

Updates to destinations to match exampleDestination.

@bsneed
Copy link
Contributor

bsneed commented Sep 21, 2021

Please rename your PRs to something meaningful. When you squash merge, the changeling is going to say "Migs647/exampledestination2" which isn't useful in a change log. 🗡️

@@ -17,7 +17,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool {
// Override point for customization after application launch.

let configuration = Configuration(writeKey: "WRITE_KEY")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prob don't want a write key in here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, missed that cause of the merge conflict

@migs647 migs647 changed the title Migs647/exampledestination2 Updates to destinations to match ExampleDestination Sep 21, 2021
@migs647 migs647 merged commit bd23547 into main Sep 21, 2021
@migs647 migs647 deleted the migs647/exampledestination2 branch September 21, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants