fix: screen event needs to be setup properly #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The screen call would be calling to the wrong process method so that the event would not be set up correctly.
bsneed
approved these changes
Nov 17, 2021
|
thanks @pietropizzi ! I found another instance of this in group as well. Nice catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The screen call would be calling to the wrong process method so that the event would not be set up correctly. In my case the
integrationswere not setup correctly so when I usedenableCloudIntegrationon the rawEvent it would throw an error complaining that integrations is not a dictionary.I ran all the tests and they are passing. I did not find any tests specifically for this behaviour and was not familiar enough with the codebase to do that myself.