Add commitizen and commitlint #99
Conversation
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
=======================================
Coverage 98.58% 98.58%
=======================================
Files 11 11
Lines 636 636
=======================================
Hits 627 627
Misses 9 9Continue to review full report at Codecov.
|
fathyb
force-pushed
the
chore/commit-convention
branch
2 times, most recently
from
b8dae8c to
1fb74d1
Compare
.circleci/config.yml
Outdated
| @@ -17,6 +17,8 @@ jobs: | |||
| key: yarn-dependency-cache-{{ checksum "yarn.lock" }} | |||
| paths: | |||
| - node_modules | |||
| - run: git fetch origin master | |||
| - run: yarn commitlint --from $(git merge-base --fork-point FETCH_HEAD) | |||
There was a problem hiding this comment.
Can we do this as part of make test?
There was a problem hiding this comment.
After testing a bit turns out it can be difficult to find which commits are relevant just using git locally. I switched to using the PR URL and the compare URL in CircleCI env to find out which commit should be checked.
| @@ -106,5 +104,23 @@ | |||
| "sinon": "^1.7.3", | |||
| "snyk": "^1.83.0", | |||
| "watchify": "^3.7.0" | |||
| }, | |||
| "commitlint": { | |||
There was a problem hiding this comment.
In the commitmsg husky hook :
analytics.js-core/package.json
Line 20 in 1fb74d1
Or manually : yarn commitlint --from HEAD~2
fathyb
force-pushed
the
chore/commit-convention
branch
from
1fb74d1 to
13d2b5c
Compare
Follow up to @f2prateek work on #98.
commitizento help new contributorscommitlintto check that commits are conform to our convention using acommitmsghook