-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github: update to Go 1.18.1 #76
Conversation
5ea8e96
to
c968b9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we dropping compatibility with 1.16 if we remove +build?
Yes, I think so, but note the go formatter is doing this automatically. So we either need to use 1.16/1.17 to generate these files always, or upgrade. IMO if you care enough about perf to use this library you should be given carrots to upgrade, or interested in upgrading. |
The segmentio/encoding package depends on this one, users may have indirect dependencies on segmentio/asm, that would break compilation of their programs then. I'm not against making the change but I think we need to carefully vet the impact, and take proactive steps to mitigate it, for example:
|
For what it's worth, I think supporting the last two Go versions is a common practice since it matches the support policy of Go itself. |
.github/workflows/go.yml
Outdated
run: make --always-make build | ||
|
||
- name: Git Status | ||
- name: Ensure stubs are up to date |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name isn't correct: more than just stub files are generated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
.github/workflows/go.yml
Outdated
run: | | ||
git diff | ||
test -z "$(git status --porcelain)" | ||
go install github.com/kevinburke/differ@latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid @latest
in CI? Pin a version instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
c968b9c
to
10cc60c
Compare
Also regenerate all of the stubs, we don't need "+build" anymore because both Go 1.17 and 1.18 use "go:build" for build tags.
10cc60c
to
9e499ea
Compare
3804532
to
52fc573
Compare
Ok - I've done everything on the list here: #76 (comment) |
Also regenerate all of the stubs, we don't need "+build" anymore
because both Go 1.17 and 1.18 use "go:build" for build tags.