Skip to content
This repository has been archived by the owner on May 18, 2021. It is now read-only.

Updated Windows docs to reflect more lessons learned and current buil… #118

Merged
merged 2 commits into from
Feb 5, 2019
Merged

Updated Windows docs to reflect more lessons learned and current buil… #118

merged 2 commits into from
Feb 5, 2019

Conversation

devonbleak
Copy link
Contributor

…d process

@devonbleak devonbleak mentioned this pull request Feb 5, 2019
Closed
nickatsegment
nickatsegment approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@nickatsegment nickatsegment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks for your help. I don't think any of us core maintainers have a Windows box at hand, so this is super helpful

@nickatsegment nickatsegment merged commit 52fe61e into segmentio:master Feb 5, 2019
@devonbleak
Copy link
Contributor Author

Happy to help, we get a ton of use from this and glad to contribute back.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nickatsegment nickatsegment nickatsegment approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devonbleak @nickatsegment