This repository has been archived by the owner on May 18, 2021. It is now read-only.
Disabled transport encoding to okta to prevent EOF #148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our users would get constant "unexpected EOF" errors when trying to authenticate with 2FA against okta.
We traced the cause to trying to decode the transport encoding (gzip) on the chunked body stream in the response.
This causes
ReadAll
to return anio.EOF
err even when it should not:aws-okta/lib/okta.go
Line 516 in b1140c3
The fix that has worked is to add a header to prevent okta from encoding the response.