This repository has been archived by the owner on May 18, 2021. It is now read-only.
One keyring item for session #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can cross that bridge when we come to it
nickatsegment
force-pushed
the
one-keyring-for-session
branch
from
38f5571
to
66ee4ed
Compare
systemizer
reviewed
Jul 9, 2019
systemizer
reviewed
Jul 9, 2019
systemizer
approved these changes
Jul 9, 2019
Fauzyy
reviewed
Jul 9, 2019
Fauzyy
approved these changes
Jul 9, 2019
|
I'm gonna add some simple tests. |
Introduces golang.org/x/xerrors, until we can start to use go 1.13 errors reliably.
Just use stdlib errors + xerrors
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #146
Partially addresses #173
Adds a
--session-cache-single-itemflag and env var to opt into a new session cache that stores all sessions in a single keyring item. The benefit is fewer auth prompts from macOS Keychain. On every upgrade (new aws-okta binary), the user needs to reauth 3 + N (number of sessions) times, but with this new cache, this is always just 3+1.This refactors the
KeyringSessionstype into a session cache store and a keying function interface so that we can reuse the existing (bizarre) keying function with a new storage engine.I might propose in another PR that we use a better keying function. I'm still trying to understand what we want from this cache.