Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Correct directions for terminal env vars #259

Closed
Nuru opened this issue May 5, 2020 · 2 comments · Fixed by #270
Closed

Docs: Correct directions for terminal env vars #259

Nuru opened this issue May 5, 2020 · 2 comments · Fixed by #270

Comments

@Nuru
Copy link
Contributor

Nuru commented May 5, 2020

The directions for setting env vars in your terminal given in #247 are wrong.

chamber/README.md

Lines 174 to 178 in c2a0530

To set env vars in your terminal you can eval the dotenv export format. For example,
```shell
eval `chamber export foo -f dotenv`
echo $foo_var
```

This does not work correctly with various special characters. In general, use of the dotenv format should be avoided (see #208), and especially here when we have #184 specifically to handle this use case.

Recommended change:

To set env vars in your terminal you can use the chamber env command. For example,

source <(chamber env service)`
printf "%s" "$SERVICE_VAR"
@nickatsegment
Copy link
Contributor

SGTM. Wanna make a PR?

@Nuru
Copy link
Contributor Author

Nuru commented May 6, 2020

@nickatsegment I'd rather not spend time on the whole fork and PR thing, if you don't mind, and I don't need attribution. Please just go ahead and fix it in your next update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants