-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deb/rpm packages #129
Add deb/rpm packages #129
Conversation
39d8713
to
f4bc09b
Compare
f4bc09b
to
9ab4eee
Compare
a0da4c9
to
c233c14
Compare
c233c14
to
ac61113
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming you get the publish working (seems to be close), this LGTM
Doing package releases for multiple distributions is an inherently hairy problem. The additional structure in the makefiles makes it readable for engineers. I bet we can even adopt these tools pretty easiyl too.
ac61113
to
1a43e0e
Compare
After merging, I tested a real-ish prerelease tag and it works :) https://circleci.com/gh/segmentio/chamber/257 |
Basically copied segmentio/chamber#129
* Add deb/rpm package building and publishing Basically copied segmentio/chamber#129 * split linux dist/publish
dist
job, using nfpmMakefile
in toMakefile
(simple; mostly aimed at users who want to build it themselves),Makefile.release
(complex; aimed at CI/devs) andMakefile.tools
(one-off installation tasks)test
job/recipev2.1.0-anythingwithadash
) as github prereleases (mostly for testing this process)Ended up refactoring a lot of the Makefile and fixing circle in general. I had to use a fair few GNU Make tricks to get it to work in the end; maybe that's crazy
Testing deb
Testing rpm
Testing tags
git tag v2.1.0-prerelease-test ; git push origin v2.1.0-prerelease-test
Testing Packagecloud releases
git tag -f v2.1.0-prerelease-test3 && git push -f origin v2.1.0-prerelease-test3
Installing via apt on debian
Installing via yum on fedora