Fix flag shorthand conflict. #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickatsegment
requested review from
nickatsegment,
systemizer and
boggsboggs
|
@jmcarp Thanks for this! Panics: they're bad. My gut feeling is that we should drop the short form of verbose because I think it's newest, and isn't yet in a release. Will take a closer look tomorrow. |
jmcarp
force-pushed
the
fix-read-panic
branch
from
1d8b39f
to
59bc436
Compare
|
I didn't realize the |
Both the "verbose" flag in the cli root and the "version" flag in the read command use the "v" shorthand, which causes a panic on read. This patch drops the shorthand for the "verbose" flag.
jmcarp
force-pushed
the
fix-read-panic
branch
from
59bc436
to
ac4098a
Compare
nickatsegment
approved these changes
Sep 13, 2018
|
Merged! Thanks again @jmcarp; you're killing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the "verbose" flag in the cli root and the "version" flag in the
read command use the "v" shorthand, which causes a panic on read. This
patch drops the shorthand for the "version" flag.
@nickatsegment