Adding analytics for usage metrics #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds metrics to chamber so we can track internal company usage of the tool. Chamber built for open source will not have the linked analytics key
f2prateek
reviewed
Sep 19, 2018
| @@ -4,6 +4,7 @@ import ( | |||
| "strings" | |||
|
|
|||
| "github.com/pkg/errors" | |||
| analytics "github.com/segmentio/analytics-go" | |||
There was a problem hiding this comment.
I recommend using https://github.com/segmentio/analytics-go/tree/v3.0. We've already deprecated v2 and are just waiting for until the deprecation date to merge v3.0 into master.
There was a problem hiding this comment.
yup! I'm using v3 :)
nickatsegment
approved these changes
Sep 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds metrics to chamber so we can track internal company usage of the tool. Chamber built for open source will not have the linked analytics key.
This PR basically copies the way metrics were added to aws-okta