Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra history entry for the current parameter version #157

Merged
merged 1 commit into from
Nov 3, 2018
Merged

Remove extra history entry for the current parameter version #157

merged 1 commit into from
Nov 3, 2018

Conversation

mechanical-fish
Copy link
Contributor

At some point the SSM GetParameterHistory call started returning the current version in its response. (My guess is that this might have happened when AWS introduced official support for versioning, though I haven't confirmed that.) That turns the various old workarounds for the missing "current" version into bugs, like this:

$ chamber write myservice mysecret foo
$ chamber history myservice mysecret 
Event		Version		Date		User
Created		1		10-13 17:37:21	[redacted]
Created		1		10-13 17:37:21	[redacted]

$ chamber write myservice mysecret bar
$ chamber history myservice mysecret 
Event		Version		Date		User
Created		1		10-13 17:37:21	[redacted]
Updated		2		10-13 17:37:48	[redacted]
Updated		2		10-13 17:37:48	[redacted]

This PR fixes that. After the fix:

$ chamber write myservice mysecret foo
$ chamber history myservice mysecret 
Event		Version		Date		User
Created		1		10-13 17:48:15	[redacted]

$ chamber write myservice mysecret bar
$ chamber history myservice mysecret 
Event		Version		Date		User
Created		1		10-13 17:48:15	[redacted]
Updated		2		10-13 17:48:21	[redacted]

@nickatsegment nickatsegment merged commit 0317aaf into segmentio:master Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants