add NewS3StoreWithBucket constructor #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate NewS3Store to avoid env var in lib
systemizer
reviewed
Nov 7, 2018
|
looks great the one thing i worry about is whether someone is depending on the environment variable with the library. But given this is an experimental feature and we haven't started using it, I agree with this approach |
systemizer
approved these changes
Nov 7, 2018
|
I think the reliance on an env var for a critical piece of info makes its utility as a library pretty limited. You'd need a lock around creation to make sure the env var is in the correct state. I considered just replacing NewS3Store. But I think deprecating and targeting removal in v3 is the best way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate NewS3Store to avoid env var in lib