-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate release process using a github action module #337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look reasonable to me. Seems like a much simpler approach 👍
Just double checking, though, does the output paths of the files match what was previously generated in the other tool?
For example, the current release artifacts on GitHub have the pattern
chamber-v<VERSION>-<OS>-<ARCHITECHTURE>
Will this new release tool do the same format? Want to make sure there is consistency in case we have some automated tool that downloads based on that format.
Also, the example in the PR body shoes the Docker Publish failing as well. Is that still a concern?
We haven't changed the file format. We're still using same script to generate them. See https://github.com/segmentio/chamber/blob/master/Makefile.release#L155
We're using the docker hub creds that belong to a different account that's why it's failing. We're waiting a response from IT to get the creds for the correct account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM then.
Do we have plans to remove the CircleCI webhook given that we removed the CircleCI configuration?
I'm looking forward to remove that once we ensure everything is working. Let's say we need to rollback for some reason, I wouldn't like to depend on IT to get us another webhook url. |
The PR merge we made created an error when publishing to github. We decided to move away from the
github-release
step in the Makefile and use Github actions steps instead to publish to github. Since this is automated and more streamlined that what the Makefile is doing. Through this, we also decided to use the automated CHANGELOG generation provided by Github Actions.Here is the error for the PR that was merged: https://github.com/segmentio/chamber/actions/runs/2116343973