fix: enhance error message to clarify validity of forward slashes in service names #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mckern
reviewed
May 24, 2022
* use single space after period * treat 'full stop' and 'forward slash' as separate words
mckern
approved these changes
May 25, 2022
kevcube
pushed a commit
to kevcube/chamber
that referenced
this pull request
May 31, 2022
…service names (segmentio#347) * fix: enhance error message to clarify validity of forward slashes in service names * chore: add test case for leading colon in service with label * fix: grammar enhancements * use single space after period * treat 'full stop' and 'forward slash' as separate words
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enhance error message to clarify validity of forward slashes in service names
Resolves #333