-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github: update to Go 1.21 #426
Conversation
81e58ba
to
f020c63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment
Also, can we make sure the Dockerfile value matches as well?
Thanks for opening this up!
.github/workflows/build.yml
Outdated
@@ -28,11 +28,11 @@ jobs: | |||
test: | |||
strategy: | |||
matrix: | |||
go: ["1.20.x", "1.19.x"] | |||
go: ["1.21.x", "1.20.x"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we missing 1.19.x
here as well? Looks like we set that for installing modules and for the dist
strategy below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fixed
go.mod
Outdated
@@ -1,22 +1,22 @@ | |||
module github.com/segmentio/chamber/v2 | |||
|
|||
go 1.19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to bump this as well?
IIRC, we hesitated on bumping this because of breaks to packages that pull in chamber
as a dependency.
I would vote to keep this on 1.19 now since this represents a minimum version for pulling in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, you're right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fixed
Also update go.mod version and dependencies to latest versions.
f020c63
to
eea2ea5
Compare
Also update go.mod version and dependencies to latest versions.