.github: update to Go 1.21 #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinburkesegment
force-pushed
the
go-1.21
branch
from
81e58ba
to
f020c63
Compare
alecjacobs5401
requested changes
Oct 10, 2023
There was a problem hiding this comment.
One minor comment
Also, can we make sure the Dockerfile value matches as well?
Thanks for opening this up!
.github/workflows/build.yml
Outdated
| @@ -28,11 +28,11 @@ jobs: | |||
| test: | |||
| strategy: | |||
| matrix: | |||
| go: ["1.20.x", "1.19.x"] | |||
| go: ["1.21.x", "1.20.x"] | |||
There was a problem hiding this comment.
are we missing 1.19.x here as well? Looks like we set that for installing modules and for the dist strategy below
There was a problem hiding this comment.
This is fixed
go.mod
Outdated
| @@ -1,22 +1,22 @@ | |||
| module github.com/segmentio/chamber/v2 | |||
|
|
|||
| go 1.19 | |||
There was a problem hiding this comment.
do we need to bump this as well?
IIRC, we hesitated on bumping this because of breaks to packages that pull in chamber as a dependency.
I would vote to keep this on 1.19 now since this represents a minimum version for pulling in
There was a problem hiding this comment.
Ah, you're right
There was a problem hiding this comment.
This is fixed
Also update go.mod version and dependencies to latest versions.
kevinburkesegment
force-pushed
the
go-1.21
branch
from
f020c63
to
eea2ea5
Compare
knksmith57
approved these changes
Oct 18, 2023
alecjacobs5401
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update go.mod version and dependencies to latest versions.