ci: bump actions/upload-artifact and actions/download-artifact to v4 #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecjacobs5401
commented
Jan 16, 2024
| @@ -22,7 +22,7 @@ jobs: | |||
|
|
|||
| - name: Make distributables | |||
| run: make -f Makefile.release dist | |||
| - uses: actions/upload-artifact@v3 | |||
| - uses: actions/upload-artifact@v4 | |||
| with: | |||
| name: dist | |||
There was a problem hiding this comment.
I opted to leave this as dist, but was tempted to make it dist-release for more defined uniqueness. Any input?
There was a problem hiding this comment.
Ah, missed this. Going to leave as is for now and we can circle back around if we feel strongly.
Sabrina0614
approved these changes
Jan 16, 2024
mckern
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We're seeing some consistent 400 responses in our
diststeps for our GitHub actions. After doing some digging, it looks like the v4 version of the Artifacts GitHub Actions was made available in early December that should resolve and/or make more reliable these actions.Changes
The
v4versions of these actions come with some breaking changes and requirements that are addressed in this PR:actions/upload-artifacts@v4, we must also be usingactions/download-artifacts@v4