Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added list sorting options #95

Merged
merged 1 commit into from
Nov 2, 2018
Merged

added list sorting options #95

merged 1 commit into from
Nov 2, 2018

Conversation

brycehendrix
Copy link
Contributor

This adds sorting options to the list command which is extremely useful in services with many secrets.

Copy link
Contributor

@dfuentes dfuentes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small note, but otherwise looks great

cmd/list.go Show resolved Hide resolved
@brycehendrix
Copy link
Contributor Author

Not sure what the PR process here is- the PR was approved 2 weeks ago, but I don't have access to merge. Will it be merged as the next release is prepared?

@nickatsegment
Copy link
Contributor

Sorry for the delay! Thanks for your contribution.

@nickatsegment nickatsegment merged commit c82e7fc into segmentio:master Nov 2, 2018
@nickatsegment
Copy link
Contributor

nickatsegment commented Nov 2, 2018

Looks like the merge broke the build (probably bitrot); fixing.

https://circleci.com/workflow-run/6fc9089d-ecc6-4f58-baa8-bb10a84cb265

nickatsegment added a commit that referenced this pull request Nov 2, 2018
@nickatsegment
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants