This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
added cdnHost #110
Merged
added cdnHost #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dk1027
commented
Jul 9, 2020
| @@ -12,7 +12,7 @@ At its core, the Consent Manager empowers your visitors to control and customize | |||
|
|
|||
| It works by taking control of the analytics.js load process to only load destinations that the user has consented to and not loading analytics.js at all if the user has opted out of everything. The user's tracking preferences are saved to a cookie and sent as an identify trait (if they haven't opted out of everything) so that you can also access them on the server-side and from destinations (warehouse). | |||
|
|
|||
| *Segment works to ensure the Consent Manager Tech Demo works with most of our product pipeline. We cannot ensure it works in your specific implementation or website. Please contact our Professional Services team for implementation support. Please see the License.txt included.* | |||
| _Segment works to ensure the Consent Manager Tech Demo works with most of our product pipeline. We cannot ensure it works in your specific implementation or website. Please contact our Professional Services team for implementation support. Please see the License.txt included._ | |||
There was a problem hiding this comment.
These are prettier changes; My changes are adding documentation for cdnHost
dk1027
commented
Jul 9, 2020
| @@ -88,7 +88,7 @@ | |||
| "lodash-es": "^4.17.10", | |||
| "nock": "^9.2.5", | |||
| "preact": "^10.0.0", | |||
| "prettier": "1.18.2", | |||
| "prettier": "^1.19.1", | |||
There was a problem hiding this comment.
Bumping this to the latest 1.x.x version because 1.18.2 fails on the nullish coalescing operator ?? operator
dk1027
commented
Jul 9, 2020
| defaultDestinationBehavior={defaultDestinationBehavior} | ||
| workspaceAddedNewDestinations={workspaceAddedNewDestinations} | ||
| /> | ||
| return ( |
There was a problem hiding this comment.
These are prettier changes, aside from adding cdnHost.
notfelineit
reviewed
Jul 13, 2020
| @@ -324,6 +324,49 @@ describe('ConsentManagerBuilder', () => { | |||
| ) | |||
| }) | |||
|
|
|||
| test('a different cdn is used when cdnHost is set', done => { | |||
notfelineit
approved these changes
Jul 13, 2020
|
Hey, since the example will be identical as the two basic examples except for using the new property, I think it would be best if we don't create another example. I've updated the readme so people can discover the |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added configurable CDN host
This PR added a new prop
cdnHosttoConsentManagerandConsentManagerBuilderwith a default value ofcdn.segment.comwhich is the same as the existing behavior. This allows users to use their own CDN instead of Segment's.Testing
Testing is done via unit tests and story book on my local dev environment.
Default behavior is unchanged
React component: Setting cdnHost to another CDN
Standalone script: Setting cdnHost to another CDN
