Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Sync fork into official version #164

Merged
merged 32 commits into from
Sep 10, 2021
Merged

Sync fork into official version #164

merged 32 commits into from
Sep 10, 2021

Conversation

dmitry-zaets
Copy link
Contributor

This PR introduces:

  • Fix On Standalone script closeBehavior: accept does not work  #104
  • A possibility to add default buttons to accept/deny cookies via bannerActionsBlock
  • A possibility to add custom buttons block via bannerActionsBlock
  • Hide Clone button via bannerHideCloseButton
  • Fix the dialog on iPhone
  • Add option to show banner as modal
  • Use only loadsh-es and remove lodash package and include only used functions instead of the whole package (reduce the final bundle size)
  • Update webpack CLI

Screenshots:

A possibility to add default buttons to accept/deny cookies via bannerActionsBlock

Default Buttons Without Close Button
image image

A possibility to add custom buttons block via bannerActionsBlock

Custom Buttons Without Close Button
image image

Mobile:

Default Buttons Without Close Button Custom Buttons Without Close Button
image image image image

Fix the dialog on iPhone

Before After
4437EEAD-15AE-406D-9CEC-DC3CFF10CA22 B117A412-708B-48B3-9161-87A0C445887E

Banner as Modal

image

Copy link
Contributor

@pooyaj pooyaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmitry-zaets amazing work 🙌

@pooyaj pooyaj merged commit 14fafda into segmentio:master Sep 10, 2021
@camwest
Copy link

camwest commented Sep 12, 2021

@dmitry-zaets what's the ETA on cutting this release? Very excited!

@felipe-najson-ntf
Copy link
Contributor

Hi @camwest! We will be working this week to publish the new version of the library.

Segment team.

@pooyaj
Copy link
Contributor

pooyaj commented Sep 13, 2021

@camwest @felipe-najson-ntf 5.3.0 is now available on npm 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Consent Manager
Needs Review
4 participants