This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Sep 10, 2021
Closed
pooyaj
approved these changes
Sep 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmitry-zaets amazing work 🙌
@dmitry-zaets what's the ETA on cutting this release? Very excited! |
Hi @camwest! We will be working this week to publish the new version of the library. Segment team. |
@camwest @felipe-najson-ntf |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces:
bannerActionsBlock
bannerActionsBlock
bannerHideCloseButton
loadsh-es
and removelodash
package and include only used functions instead of the whole package (reduce the final bundle size)Screenshots:
A possibility to add default buttons to accept/deny cookies via
bannerActionsBlock
A possibility to add custom buttons block via
bannerActionsBlock
Mobile:
Fix the dialog on iPhone
Banner as Modal