Add protobuf rewrite rule overrides #144
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an override mechanism for specifying alternative
proto.Rewriter
's when performing template rewrites. These new rules can be provided as an optional set of parameters toproto.ParseRewriteTemplate
, so this does not change the calling signature when rules are not used. When provided, these rules are matched against the field name in a nested fashion (see the tests for an example).We have some cases where we need to rewrite flags that are encoded as a single integer bit mask. By combining these rules with the new
proto.BitOr
type, we can merge flags instead of replacing them: