Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @blueprintjs/icons to ^3.6.0 #525

Closed

Conversation

ggallon
Copy link

@ggallon ggallon commented Mar 19, 2019

Hi,

This upgrade add new icons : inbox-filtered, inbox-geo, inbox-search, inbox-update, cube, cube-add, cube-remove, lifesaver, table-filtered and clean.

@blueprintjs/icons 3.6.0 : palantir/blueprint#3335 (comment)
@blueprintjs/icons 3.4.0 : palantir/blueprint#3222 (comment)
@blueprintjs/icons 3.3.0 : palantir/blueprint#3052 (comment)

@mshwery
Copy link
Contributor

mshwery commented Mar 20, 2019

Looks like size limit is failing with this upgrade.

@ggallon
Copy link
Author

ggallon commented Mar 20, 2019

Hi @mshwery,

I saw, this upgrade impact the package size of 3.53 KB:

  • New size: 207.53 KB
  • Size limit: 204 KB

I can increase the size limit to 207.53 or 208 KB?

@mshwery
Copy link
Contributor

mshwery commented Mar 20, 2019

@ggallon I would love if there was a way to add tree shaking to the icons in a non-breaking way. I'm hesitant to knowingly increase everyone's bundle size to add a few icons that they don't use today...

We could bump the size limit to 208 for now, but I want to start thinking about ways to actively reduce the bundle size (tree-shaking icons is probably the biggest one).

Potentially another way we could handle it is treat icons as a BYO- bring your own –icons to evergreen... We'd have to provide our own default icons for everything that Evergreen relies on internally (search, close, add, checkmark, etc).

@stale
Copy link

stale bot commented May 19, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wont-fix label May 19, 2019
@stale stale bot closed this May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants