Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the outdated part of the documentation #1030

Merged
merged 2 commits into from
Nov 18, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion describeconfigs.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ type DescribeConfigsRequest struct {
// Address of the kafka broker to send the request to.
Addr net.Addr

// List of resources to update.
// List of resources to get details for.
Resources []DescribeConfigRequestResource

// Ignored if API version is less than v1
Expand Down
4 changes: 0 additions & 4 deletions writer.go
Original file line number Diff line number Diff line change
Expand Up @@ -307,10 +307,6 @@ type WriterConfig struct {
// a response to a produce request. The default is -1, which means to wait for
// all replicas, and a value above 0 is required to indicate how many replicas
// should acknowledge a message to be considered successful.
//
// This version of kafka-go (v0.3) does not support 0 required acks, due to
// some internal complexity implementing this with the Kafka protocol. If you
// need that functionality specifically, you'll need to upgrade to v0.4.
RequiredAcks int

// Setting this flag to true causes the WriteMessages method to never block.
Expand Down