Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update snippet and improve CI #140

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Update snippet and improve CI #140

merged 3 commits into from
Dec 4, 2023

Conversation

silesky
Copy link
Contributor

@silesky silesky commented Nov 30, 2023 •
edited
Loading

  • Remove final newline
  • Add Linting and CI
  • Refactor so the first part of the minified snippet is 'analytics' again

Will do a minor version bump (5.1.0)

@silesky silesky force-pushed the update-snippet-aesthetics branch from 213d54c to 95a4a9f Compare November 30, 2023 23:06
@silesky silesky requested a review from chrisradek November 30, 2023 23:06
@silesky silesky force-pushed the update-snippet-aesthetics branch from 95a4a9f to bbb8187 Compare November 30, 2023 23:08
@silesky silesky changed the title update snippet aesthetics Update snippet and fix eslint Nov 30, 2023
@silesky silesky changed the title Update snippet and fix eslint Update snippet (aesthetics) and fix eslint Nov 30, 2023
@silesky silesky changed the title Update snippet (aesthetics) and fix eslint Update snippet and improve CI Dec 1, 2023
@silesky silesky force-pushed the update-snippet-aesthetics branch 3 times, most recently from c159ab6 to 67fc08a Compare December 1, 2023 06:17
@silesky silesky force-pushed the update-snippet-aesthetics branch from 67fc08a to 270acbc Compare December 1, 2023 06:28
@silesky silesky force-pushed the update-snippet-aesthetics branch from 68e608e to 06ad128 Compare December 1, 2023 06:35
@silesky silesky requested a review from oscb December 1, 2023 06:35
@silesky silesky merged commit 025d119 into master Dec 4, 2023
1 check passed
@silesky silesky deleted the update-snippet-aesthetics branch December 4, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscb oscb oscb approved these changes

@chrisradek chrisradek chrisradek approved these changes

@danieljackins danieljackins Awaiting requested review from danieljackins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silesky @oscb @chrisradek